GH-4619: Fixed Ollama Embedding : keep_alive format #4621
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lance <[email protected]>
| } | ||
|
|
||
| return new OllamaApi.EmbeddingsRequest(requestOptions.getModel(), embeddingRequest.getInstructions(), | ||
| DurationParser.parse(requestOptions.getKeepAlive()), |
There was a problem hiding this comment.
The subclass DurationParser can also be removed.
|
@leelance Thanks for the PR! Along with the review comment, Could you also fix the failing tests? |
Thanks! I’m already working on fixing the failing tests — will update the PR soon. |
Signed-off-by: lance <[email protected]>
|
Rebased, squashed and merged as f32b122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #4619
The update ensures that the keep_alive value follows the proper time duration format (e.g., "3h", "30m", "15s") recognized by the Ollama API.