Skip to content

Conversation

nicolaskrier
Copy link
Contributor

@nicolaskrier nicolaskrier commented Sep 10, 2025

  • Use Ollama's system role for system messages (instead of user role).
  • Add unit test to validate Spring AI to Ollama message conversion for all message types.

@nicolaskrier
Copy link
Contributor Author

Hi @ilayaperumalg, could you check this PR please? It is relative to this commit.

@sunyuhan1998
Copy link
Contributor

You're right, that was my oversight in that PR. Thank you very much for the correction!

@ilayaperumalg
Copy link
Member

@nicolaskrier Thanks for the quick fix and sorry about missing that during the merge. Will get to this shortly.

@ilayaperumalg ilayaperumalg self-assigned this Sep 11, 2025
@ilayaperumalg ilayaperumalg added this to the 1.1.0.M2 milestone Sep 11, 2025
@ilayaperumalg ilayaperumalg added the bug Something isn't working label Sep 11, 2025
@ilayaperumalg ilayaperumalg merged commit 4fa32e6 into spring-projects:main Sep 11, 2025
2 checks passed
@nicolaskrier nicolaskrier deleted the ollama-system-message branch September 11, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ollama

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants