Bedrock converse chat model to merge toolcalling chat options #4314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ilayaperumalg
commented
Sep 4, 2025
ilayaperumalg
commented
- When building the chat client request, if the ToolCallingChatOptions is passed via prompt, merge the options into Bedrock chat options. Previously, this was ignored.
- Add test to verify function calling when ToolCallingChatOptions is passed
- When building the chat client request, if the ToolCallingChatOptions is passed via prompt, merge the options into Bedrock chat options. Previously, this was ignored. - Add test to verify function calling when ToolCallingChatOptions is passed Signed-off-by: Ilayaperumal Gopinathan <[email protected]>
|
LGTM, thanks @ilayaperumalg |
spring-builds
pushed a commit
that referenced
this pull request
Sep 5, 2025
- When building the chat client request, if the ToolCallingChatOptions is passed via prompt, merge the options into Bedrock chat options. Previously, this was ignored. - Add test to verify function calling when ToolCallingChatOptions is passed Fixes: #4314 Signed-off-by: Ilayaperumal Gopinathan <[email protected]> (cherry picked from commit 26166a1)
SenreySong
pushed a commit
to SenreySong/spring-ai
that referenced
this pull request
Sep 8, 2025
…-projects#4314) - When building the chat client request, if the ToolCallingChatOptions is passed via prompt, merge the options into Bedrock chat options. Previously, this was ignored. - Add test to verify function calling when ToolCallingChatOptions is passed Auto-cherry-pick to 1.0.x Fixes: spring-projects#4314 Signed-off-by: Ilayaperumal Gopinathan <[email protected]>
chedim
pushed a commit
to couchbaselabs/spring-ai
that referenced
this pull request
Sep 19, 2025
…-projects#4314) - When building the chat client request, if the ToolCallingChatOptions is passed via prompt, merge the options into Bedrock chat options. Previously, this was ignored. - Add test to verify function calling when ToolCallingChatOptions is passed Auto-cherry-pick to 1.0.x Fixes: spring-projects#4314 Signed-off-by: Ilayaperumal Gopinathan <[email protected]>
Willam2004
pushed a commit
to Willam2004/spring-ai
that referenced
this pull request
Oct 11, 2025
…-projects#4314) - When building the chat client request, if the ToolCallingChatOptions is passed via prompt, merge the options into Bedrock chat options. Previously, this was ignored. - Add test to verify function calling when ToolCallingChatOptions is passed Auto-cherry-pick to 1.0.x Fixes: spring-projects#4314 Signed-off-by: Ilayaperumal Gopinathan <[email protected]> Signed-off-by: 家娃 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.