Skip to content

Conversation

markpollack
Copy link
Member

  • Created new VectorStoreRetriever functional interface for read-only operations
  • Modified VectorStore to extend VectorStoreRetriever
  • Removed duplicate similaritySearch methods from VectorStore
  • Updated API documentation to reflect the interface separation
  • Added package-info.java documentation for clarity

This change follows the principle of least privilege by providing a read-only interface for retrieval operations while maintaining the full functionality in VectorStore.

Fixes #1290

Thank you for taking time to contribute this pull request!
You might have already read the contributor guide, but as a reminder, please make sure to:

  • Add a Signed-off-by line to each commit (git commit -s) per the DCO
  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

For more details, please check the contributor guide.
Thank you upfront!

- Created new VectorStoreRetriever functional interface for read-only operations
- Modified VectorStore to extend VectorStoreRetriever
- Removed duplicate similaritySearch methods from VectorStore
- Updated API documentation to reflect the interface separation
- Added package-info.java documentation for clarity

This change follows the principle of least privilege by providing a read-only
interface for retrieval operations while maintaining the full functionality
in VectorStore.

Fixes spring-projects#1290

Signed-off-by: Mark Pollack <[email protected]>
@sobychacko sobychacko merged commit cf2c3c5 into spring-projects:main Jul 17, 2025
2 checks passed
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
…cts#3827)

- Created new VectorStoreRetriever functional interface for read-only operations
- Modified VectorStore to extend VectorStoreRetriever
- Removed duplicate similaritySearch methods from VectorStore
- Updated API documentation to reflect the interface separation
- Added package-info.java documentation for clarity

This change follows the principle of least privilege by providing a read-only
interface for retrieval operations while maintaining the full functionality
in VectorStore.

Fixes spring-projects#1290

Signed-off-by: Mark Pollack <[email protected]>
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
…cts#3827)

- Created new VectorStoreRetriever functional interface for read-only operations
- Modified VectorStore to extend VectorStoreRetriever
- Removed duplicate similaritySearch methods from VectorStore
- Updated API documentation to reflect the interface separation
- Added package-info.java documentation for clarity

This change follows the principle of least privilege by providing a read-only
interface for retrieval operations while maintaining the full functionality
in VectorStore.

Fixes spring-projects#1290

Signed-off-by: Mark Pollack <[email protected]>
Willam2004 pushed a commit to Willam2004/spring-ai that referenced this pull request Oct 11, 2025
…cts#3827)

- Created new VectorStoreRetriever functional interface for read-only operations
- Modified VectorStore to extend VectorStoreRetriever
- Removed duplicate similaritySearch methods from VectorStore
- Updated API documentation to reflect the interface separation
- Added package-info.java documentation for clarity

This change follows the principle of least privilege by providing a read-only
interface for retrieval operations while maintaining the full functionality
in VectorStore.

Fixes spring-projects#1290

Signed-off-by: Mark Pollack <[email protected]>
Signed-off-by: 家娃 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VectorStore interface should be split, with readonly operations becoming a super interface

2 participants