GH 3421 : Fix silent failures in PDF outline processing #3623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…line items Signed-off-by: WOONBE <[email protected]>
…h imperfect outlines and coordinate edge cases Signed-off-by: WOONBE <[email protected]>
…d Outline Signed-off-by: WOONBE <[email protected]>
Signed-off-by: WOONBE <[email protected]>
There was a problem hiding this comment.
Please rearrange the import statements in the following order:
java.*packages- Other packages
org.springframework.*packages- Static imports
For reference, you can refer to the example in this file:
OpenAiApiIT.java.
| public String getTextBetweenParagraphs(Paragraph fromParagraph, Paragraph toParagraph) { | ||
|
|
||
| if (fromParagraph.startPageNumber() < 1) { | ||
|
|
There was a problem hiding this comment.
Is this an intended line break?
Comment on lines
224
to
225
| if (h < 0) | ||
| h = 0; |
There was a problem hiding this comment.
Please add curly braces to the if statement
Signed-off-by: WOONBE <[email protected]>
Signed-off-by: WOONBE <[email protected]>
|
Please update the Copyright Notice year in the header of all modified files from 2023-2024 to 2023-2025. |
Signed-off-by: WOONBE <[email protected]>
|
@WOONBE Thanks for the PR and @dev-jonghoonpark Thanks for the review! Rebased and merged as d92a2ea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified in issue #3421, the
ParagraphPdfDocumentReaderis not resilient to common imperfections in PDF outline structures. This can lead to anIndexOutOfBoundsExceptionor, more critically, silent failures where valid sections of the document are skipped, resulting in an empty or incomplete list of documents.This PR includes the following changes:
Corrects the iteration logic in the
get()method by replacing the buggy iterator-based loop, which failed to process the last outline item, with an indexedforloop that guarantees every paragraph is processed correctly.Adds a defensive fallback for page range calculation in
getTextBetweenParagraphs().Refactors the text extraction area calculation, replacing the flawed logic that produced zero-height rectangles.
Adds a unit test that reproduces the exact condition that caused the IndexOutOfBoundsException.
Fixed #3421