Skip to content

Conversation

AA-Turner
Copy link
Member

Purpose

Following #13073, we can now consider removing the project extras (docs, lint, and test). These were never intended for external use, but theoretically downstreams could attempt to install sphinx[blah]. As such, I've currently proposed a middle ground of removing all optional dependencies but keeping the extra names themselves. I am open to arguments to just remove them, though, or to wait on removing them.

I don't know if this has an impact on redistributors, but I imagine that they will have a larger plan for PEP 735 in the abstract.

References

A

@AA-Turner AA-Turner marked this pull request as draft March 20, 2025 18:42
@jayaddison
Copy link
Contributor

@AA-Turner NB: I think one or two of the GitHub Actions CI workflows still rely on the old-style pip install .[foo] (e.g. here) - I think those might fail with these changes?

@AA-Turner AA-Turner marked this pull request as ready for review April 28, 2025 18:16
@AA-Turner AA-Turner changed the title Remove project extras Remove project extras (optional dependencies) Aug 2, 2025
@AA-Turner AA-Turner merged commit 3dddb1c into sphinx-doc:master Aug 2, 2025
8 checks passed
@AA-Turner AA-Turner deleted the remove-extras branch August 2, 2025 13:37
@rffontenelle
Copy link
Contributor

@AA-Turner sphinx-doc-translations has 'docs' in requirements.txt and in .readthedocs.yml. How does this PR affects this scenario?

@AA-Turner
Copy link
Member Author

My earlier testing was that pip and uv only warn on a missing extra, rather than refusing to resolve/install, so we should be fine. Let me know if you discover any problems, we can revert this PR.

A

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants