-
Notifications
You must be signed in to change notification settings - Fork 11
StrongName the assemblies to allow [InternalsVisibleTo] to work correctly in test projects #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add strongnaming to directory.props Update internalsvisible to in TestLogger to include strongname
|
Thanks @blowdart! |
This was referenced Oct 8, 2025
Closed
Closed
This was referenced Oct 27, 2025
Closed
Closed
Open
This was referenced Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198
Reference: Library author guidance for Strong naming
If you want to generate your own strong name keypair rather than blindly trust mine (it doesn't really matter, they're not a security boundary) then you would do the following
sn -k strongNameKey.snk(docs)sn -p strongNameKey.snk strongNameKey.pub(docs)sn -tp strongNameKey.pubPublic key (hash alghorithm: sha1)into your clipboardInternalsVisibleto attribute inTestLogger\assembly.csto use the new public key.You'll have to delete the
\r\nthat's there when you paste the value into VS (your choice of code editor may vary)I'm happy to put my work hat on (the .NET Security PM 😁) and answer any questions you might have.