Skip to content

Conversation

@alcen
Copy link
Contributor

@alcen alcen commented Jul 31, 2019

This commit will ensure that comments for grading are stored properly and accessible by students and staff.

Key changes:

  • 'comments' field added to 'Answer' schema

  • Updated tests

Refer to this frontend Pull Request for more information:
source-academy/frontend#789

alcen added 2 commits July 30, 2019 16:14
* Set up Ecto migrations for new 'comments' column

* Updated Phoenix controllers and views

* Configure unsubmit submission to remove 'comments' field

* Updated test scripts
@coveralls
Copy link

coveralls commented Jul 31, 2019

Pull Request Test Coverage Report for Build 2610

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.741%

Totals Coverage Status
Change from base Build 2608: 0.0%
Covered Lines: 989
Relevant Lines: 1033

💛 - Coveralls

Copy link
Contributor

@geshuming geshuming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geshuming geshuming merged commit d992e0c into master Aug 3, 2019
@alcen alcen deleted the reinstate-comments branch August 3, 2019 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants