Skip to content

Conversation

@mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Nov 1, 2025

Summary

Adds YARD documentation to SolidusPromotions::Condition. It's AI-generated, but vetted by me, and all correct.

I've removed the docs for #level because #6357 will deprecate it.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@mamhoff mamhoff requested a review from a team as a code owner November 1, 2025 09:35
@github-actions github-actions bot added the changelog:solidus_promotions Changes to the solidus_promotions gem label Nov 1, 2025
@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.35%. Comparing base (06ebabf) to head (f33f6c7).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6358   +/-   ##
=======================================
  Coverage   89.34%   89.35%           
=======================================
  Files         961      961           
  Lines       20173    20173           
=======================================
+ Hits        18024    18026    +2     
+ Misses       2149     2147    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

`#level` will be deprecated soon, but Codecov still complains.
@mamhoff mamhoff force-pushed the add-yard-docs-to-solidus-promotions-condition branch from 5503dfb to f33f6c7 Compare November 1, 2025 13:21
@tvdeyen tvdeyen added this to the 4.7 milestone Nov 3, 2025
@mamhoff mamhoff merged commit ca16162 into solidusio:main Nov 4, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_promotions Changes to the solidus_promotions gem

Projects

Development

Successfully merging this pull request may close these issues.

2 participants