Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ def can_discount?(object)
def level
:line_item
end
deprecate :level, deprecator: Spree.deprecator
end
end
end
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ def can_discount?(_)
def level
:order
end
deprecate :level, deprecator: Spree.deprecator
end
end
end
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ def can_discount?(object)
def level
:shipment
end
deprecate :level, deprecator: Spree.deprecator
end
end
end
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ def eligible?(promotable)
def level
:order
end
deprecate :level, deprecator: Spree.deprecator
end
end
end
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ def applicable?(promotable)
def level
:line_item
end
deprecate :level, deprecator: Spree.deprecator
end
end
end
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ def applicable?(promotable)
def level
:order
end
deprecate :level, deprecator: Spree.deprecator
end
end
end
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ def applicable?(promotable)
def level
:shipment
end
deprecate :level, deprecator: Spree.deprecator
end
end
end
1 change: 1 addition & 0 deletions promotions/app/models/solidus_promotions/benefit.rb
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ def level
raise NotImplementedError, "Please implement the correct interface, or include one of the `SolidusPromotions::Benefits::OrderBenefit`, " \
"`SolidusPromotions::Benefits::LineItemBenefit` or `SolidusPromotions::Benefits::ShipmentBenefit` modules"
end
deprecate :level, deprecator: Spree.deprecator

# Returns the set of condition classes that can still be attached to this benefit.
# Already-persisted conditions are excluded.
Expand Down
1 change: 1 addition & 0 deletions promotions/app/models/solidus_promotions/condition.rb
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ def eligible?(_promotable, _options = {})
def level
raise NotImplementedError, "level should be implemented in a sub-class of SolidusPromotions::Condition"
end
deprecate :level, deprecator: Spree.deprecator

# Returns an errors object for tracking eligibility failures.
#
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def call
private

def perform_order_benefits(lane_benefits, lane)
lane_benefits.select { |benefit| benefit.level == :order }.each do |benefit|
lane_benefits.select { |benefit| benefit.respond_to?(:perform) }.each do |benefit|
benefit.perform(order)
end

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def compute_line_item(_line_item, _options) = 1
end
end

describe "#level" do
describe "#level", :silence_deprecations do
subject { described_class.new.level }

it "raises an error" do
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
it { is_expected.to eq("solidus_promotions/admin/benefit_fields/adjust_line_item") }
end

describe "#level" do
describe "#level", :silence_deprecations do
subject { described_class.new.level }

it { is_expected.to eq(:line_item) }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
end
end

describe "#level" do
describe "#level", :silence_deprecations do
subject { described_class.new.level }

it { is_expected.to eq(:shipment) }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
let(:user) { nil }
let(:email) { nil }

describe "#level" do
describe "#level", :silence_deprecations do
it "is order" do
expect(condition.level).to eq(:order)
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
let(:condition) { described_class.new(condition_options) }
let(:condition_options) { {} }

describe "#level" do
describe "#level", :silence_deprecations do
it "is line_item" do
expect(condition.level).to eq(:line_item)
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

it { is_expected.to have_many(:products) }

describe "#level" do
describe "#level", :silence_deprecations do
it "is order" do
expect(condition.level).to eq(:order)
end
Expand Down
Loading