Skip to content

classes defined statically in classList are missing after reactive overriding #2341

@MrFoxPro

Description

@MrFoxPro

Describe the bug

classList={{
  "b-1px b-solid b-red": true,
  "b-1px b-solid b-blue": <reactive value>,
}}

After changing reactive value,b-1px and b-solid tokens will disappear.
This is not critical, because of how CSS works, this kind of expression probably is user's mistake, but behaviour is unexpected. We should better handle this case.

Your Example Website or App

https://playground.solidjs.com/anonymous/ad8fd905-fb6e-45cb-8bdc-95ad0dd309f7

classList probably should not use node.classList.toggle directly, or compare individual tokens

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions