interface: Split out instructions, state, errors from program #616

joncinque · 2025-07-31T22:20:00Z

Problem

The token-2022 program has some heavy dependencies that most users of the crate don't care about. This causes dependency issues and long compilation times.

Also, the program uses Agave dependencies, which creates circular dependencies and makes it impossible to upgrade to SDK v3 without some complicated gymnastics.

Summary of changes

Similar to the ATA's interface crate, split out everything need by Agave into a separate crate, which can also be used by on-chain programs as an rlib, and thus allow for LTO in program builds.

#### Problem The token-2022 program has some heavy dependencies that most users of the crate don't care about. This causes dependency issues and long compilation times. Also, the program uses Agave dependencies, which creates circular dependencies and makes it impossible to upgrade to SDK v3 without some complicated gymnastics. #### Summary of changes Similar to the ATA's interface crate, split out everything need by Agave into a separate crate, which can also be used by on-chain programs as an rlib, and thus allow for LTO in program builds.

joncinque · 2025-07-31T22:40:04Z

Sorry for the size of this! The general pattern for the changes goes:

interface crate has:

error.rs
generic_token_account.rs
instruction.rs
native_mint.rs
pod.rs
serialization.rs
state.rs
extension/mod.rs
extension/mint_close_authority.rs
extension/permanent_delegate.rs
extension/immutable_owner.rs
extension/non_transferable.rs

for each extension:

mod.rs (struct definitions)
instruction.rs

The program has all of the above modules, but they just re-export everything from the interface. On top of that it has:

entrypoint.rs
pod_instruction.rs
offchain.rs (we could eventually move this down into the interface)
onchain.rs (same with this)
processor.rs
extension/reallocate.rs

And for each extension, on top of re-exporting the structs and instructions, it includes:

processor.rs
account_info.rs (for confidential transfer extensions)

lib.rs is a bit special, so some functions are split between the program and the interface as makes sense.

I also removed a dependency on spl-token for my future sanity.

This might be a bit of a monster to review, but the changes should be straightforward.

rustopian · 2025-08-01T13:25:18Z

This might be a bit of a monster to review, but the changes should be straightforward.

Got it, starting to comb through it.

rustopian

Looks good. Large mechanical code relocation. Notable changes along the way:

serde_traits -> serde
removal of PodTokenInstruction passages in tests
import and import path updates
visibility + doc comment tweaks
removed test_decimals() in native_mint.rs

A few nits, but most are minor errors in the doc comments which were already present.

rustopian · 2025-08-01T14:58:45Z

interface/src/extension/interest_bearing_mint/instruction.rs

+    std::convert::TryInto,
+};
+
+/// Interesting-bearing mint extension instructions


Suggested change

/// Interesting-bearing mint extension instructions

/// Interest-bearing mint extension instructions

rustopian · 2025-08-01T15:00:19Z

interface/src/extension/interest_bearing_mint/instruction.rs

+    ///   0. `[writable]` The mint to initialize.
+    ///
+    /// Data expected by this instruction:
+    ///   `crate::extension::interest_bearing::instruction::InitializeInstructionData`


Suggested change

/// `crate::extension::interest_bearing::instruction::InitializeInstructionData`

/// `crate::extension::interest_bearing_mint::instruction::InitializeInstructionData`

rustopian · 2025-08-01T15:07:09Z

interface/src/extension/confidential_mint_burn/instruction.rs

+    pub decryptable_supply: PodAeCiphertext,
+}
+
+/// Data expected by `ConfidentialMintBurnInstruction::RotateSupplyElGamal`


Suggested change

/// Data expected by `ConfidentialMintBurnInstruction::RotateSupplyElGamal`

/// Data expected by `ConfidentialMintBurnInstruction::RotateSupplyElGamalPubkey`

rustopian · 2025-08-01T15:07:27Z

interface/src/extension/confidential_mint_burn/instruction.rs

+    pub new_supply_elgamal_pubkey: PodElGamalPubkey,
+    /// The location of the
+    /// `ProofInstruction::VerifyCiphertextCiphertextEquality` instruction
+    /// relative to the `RotateSupplyElGamal` instruction in the transaction


Suggested change

/// relative to the `RotateSupplyElGamal` instruction in the transaction

/// relative to the `RotateSupplyElGamalPubkey` instruction in the

/// transaction

rustopian · 2025-08-01T15:07:48Z

interface/src/extension/confidential_mint_burn/instruction.rs

+    ))
+}
+
+/// Create a `RotateSupplyElGamal` instruction


Suggested change

/// Create a `RotateSupplyElGamal` instruction

/// Create a `RotateSupplyElGamalPubkey` instruction

rustopian · 2025-08-01T15:08:47Z

interface/src/extension/confidential_mint_burn/instruction.rs

+    Ok(instructions)
+}
+
+/// Create a `UpdateMint` instruction


Suggested change

/// Create a `UpdateMint` instruction

/// Create an `UpdateDecryptableSupply` instruction

comment nits

program/src/native_mint.rs

joncinque · 2025-08-04T11:35:31Z

Ok everything should be addressed, thanks again for the review!

joncinque added 4 commits July 31, 2025 23:35

Rename serde-traits -> serde, remove repeated funcs

cbe86a3

Cleanup deps, remove repeated functions, run format

55ff8eb

Fix spelling issues and client generation

c262a63

joncinque requested a review from rustopian July 31, 2025 22:33

joncinque marked this pull request as ready for review July 31, 2025 22:34

rustopian reviewed Aug 4, 2025

View reviewed changes

Address nits

678c36b

rustopian approved these changes Aug 4, 2025

View reviewed changes

joncinque merged commit 690985e into solana-program:main Aug 4, 2025
23 checks passed

joncinque deleted the interface branch August 4, 2025 12:06

This was referenced Aug 4, 2025

interface: Split out instructions, state, errors from program solana-program/token#75

Closed

interface: Split out instructions, state, errors from program solana-program/token#76

Merged

This was referenced Oct 8, 2025

build failed web assembly #114

Closed

interface: API crate(s) for token2022 #65

Closed

This comment was marked as off-topic.

Sign in to view

	/// Interesting-bearing mint extension instructions
	/// Interest-bearing mint extension instructions

	/// `crate::extension::interest_bearing::instruction::InitializeInstructionData`
	/// `crate::extension::interest_bearing_mint::instruction::InitializeInstructionData`

	/// Data expected by `ConfidentialMintBurnInstruction::RotateSupplyElGamal`
	/// Data expected by `ConfidentialMintBurnInstruction::RotateSupplyElGamalPubkey`

	/// relative to the `RotateSupplyElGamal` instruction in the transaction
	/// relative to the `RotateSupplyElGamalPubkey` instruction in the
	/// transaction

	/// Create a `RotateSupplyElGamal` instruction
	/// Create a `RotateSupplyElGamalPubkey` instruction

	/// Create a `UpdateMint` instruction
	/// Create an `UpdateDecryptableSupply` instruction

interface: Split out instructions, state, errors from program #616

interface: Split out instructions, state, errors from program #616

Uh oh!

Conversation

joncinque commented Jul 31, 2025

Problem

Summary of changes

Uh oh!

joncinque commented Jul 31, 2025

Uh oh!

rustopian commented Aug 1, 2025

Uh oh!

rustopian left a comment

Choose a reason for hiding this comment

Uh oh!

rustopian Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

rustopian Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

rustopian Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

rustopian Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

rustopian Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

rustopian Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

rustopian Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joncinque commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

This comment was marked as off-topic.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joncinque commented Aug 4, 2025 •

edited

Loading