This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Cli error cleanup 1.0#8834

Merged

garious merged 29 commits intosolana-labs:v1.0from

t-nelson:cli-error-cleanup-1.0

Mar 13, 2020

Commits on Mar 13, 2020

Don't use move semantics if not needed (#8793)

jackcmay
authored and
t-nelson
committed
SDK: Deboilerplate `TransportError` with thiserror
t-nelson
committed
Enable interchange between `TransportError` and `ClientError`
t-nelson
committed
SDK: Retval consistency between `Client` and `AsyncClient` traits
t-nelson
committed
Client: Introduce/use `Result` type
t-nelson
committed
Client: Remove unused `RpcResponseIn` type
t-nelson
committed
Client: Rename `RpcResponse` to more appropriate `RpcResult`
t-nelson
committed
Client: Death to `io::Result` return types
t-nelson
committed
Client: Struct-ify `ClientError`
t-nelson
committed
Client: Add optional `command` parameter to `ClientError`
t-nelson
committed
RpcClient: Stop abusing `io::Error` (low-fruit)
t-nelson
committed
ClientError: Use `thiserror`'s `Display` impl
t-nelson
committed
Extend `RpcError`'s utility
t-nelson
committed
RpcClient: Stop abusing `io::Error` (the rest)
t-nelson
committed
CLI: Shim `main()` so we can `Display` format errors
t-nelson
committed
claputils: format input validator errors with `Display`
t-nelson
committed
SDK: `thiserror` for hash and sig parse erros
t-nelson
committed
Keygen: Shim main to format errors with `Display`
t-nelson
committed
SDK: `thiserror` for `InstructionError`
t-nelson
committed
CLI: `thiserror` for `CliError`
t-nelson
committed
CLI: Format user messages with `Display`
t-nelson
committed
Client: Tweak `Display` for `ClientError`
t-nelson
committed
RpcClient: Improve messaging when TX cannot be confirmed
t-nelson
committed
fu death io res retval
t-nelson
committed
CLI/Keygen - fix shell return value on error
t-nelson
committed
Tweak `InstructionError` `Display` messages as per review
t-nelson
committed
Cleanup hackjob return code fix
t-nelson
committed
Embrace that which you hate most
t-nelson
committed
Too much...
t-nelson
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Cli error cleanup 1.0#8834

Cli error cleanup 1.0#8834
garious merged 29 commits intosolana-labs:v1.0from
t-nelson:cli-error-cleanup-1.0

Commits on Mar 13, 2020

Don't use move semantics if not needed (#8793)

SDK: Deboilerplate `TransportError` with thiserror

Enable interchange between `TransportError` and `ClientError`

SDK: Retval consistency between `Client` and `AsyncClient` traits

Client: Introduce/use `Result` type

Client: Remove unused `RpcResponseIn` type

Client: Rename `RpcResponse` to more appropriate `RpcResult`

Client: Death to `io::Result` return types

Client: Struct-ify `ClientError`

Client: Add optional `command` parameter to `ClientError`

RpcClient: Stop abusing `io::Error` (low-fruit)

ClientError: Use `thiserror`'s `Display` impl

Extend `RpcError`'s utility

RpcClient: Stop abusing `io::Error` (the rest)

CLI: Shim `main()` so we can `Display` format errors

claputils: format input validator errors with `Display`

SDK: `thiserror` for hash and sig parse erros

Keygen: Shim main to format errors with `Display`

SDK: `thiserror` for `InstructionError`

CLI: `thiserror` for `CliError`

CLI: Format user messages with `Display`

Client: Tweak `Display` for `ClientError`

RpcClient: Improve messaging when TX cannot be confirmed

fu death io res retval

CLI/Keygen - fix shell return value on error

Tweak `InstructionError` `Display` messages as per review

Cleanup hackjob return code fix

Embrace that which you hate most

Too much...

Cli error cleanup 1.0#8834garious merged 29 commits intosolana-labs:v1.0solana-labs/solana:v1.0from t-nelson:cli-error-cleanup-1.0t-nelson/solana:cli-error-cleanup-1.0Copy head branch name to clipboard

Commits

Commits on Mar 13, 2020

Cli error cleanup 1.0#8834
garious merged 29 commits intosolana-labs:v1.0from
t-nelson:cli-error-cleanup-1.0