fix: detach screen only on activityState 0 #867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
approved these changes
Mar 25, 2021
kacperkapusciak
pushed a commit
that referenced
this pull request
Mar 30, 2021
Change the logic of displaying the Screen on web to only detach the Screen if the activityState is 0. It should prevent detaching views for during the transition.
This was referenced May 21, 2021
Closed
Closed
This was referenced Jun 6, 2021
1 task
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the logic of displaying the Screen on web to only detach the
Screenif theactivityStateis0. It should prevent detaching views for during the transition.Changes
Changed
index.tsxto match the implementation fromreact-navigation.Test code and steps to reproduce
It is needed to change the implementation of
react-navigation's navigators to usereact-native-screenson web too to test this change.Checklist