fix: make header subviews subscribe to transition #820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added change to
ScreenStackHeaderConfig.javato expose theToolbar, of which theScreenStackHeaderSubviews are the children. It is needed since theToolbaris not a child ofScreenin the view hierarchy, therefore its children are not subscribed to the transition by default. Then, in theprepareOutTransition, we add a check forScreenStackHeaderConfigand apply the transition to the children of itsToolbarmaking them stay on the screen for during the transition of going back. Fixes #817.Changes
Added method to get the
ToolbarofScreenStackHeaderConfig.Added check for getting the
ToolbarinprepareOutTransitionand firing the transition in its children.Test code and steps to reproduce
Test817.tsxinTestsExampleproject.Checklist