-
-
Notifications
You must be signed in to change notification settings - Fork 593
feat: rewrite v4 native-stack to TS #793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
c8a610d to
906cd6f
Compare
|
i wonder if we should just drop support for v4. v5 has been out for quite some time and v6 is in the works. |
|
I think we want to keep the v4. It doesn't require much work to keep it up-to-date since most of the code is on the native side, and there are still many people using |
906cd6f to
9e343e6
Compare
kacperkapusciak
approved these changes
Feb 26, 2021
This was referenced Mar 15, 2021
This was referenced May 21, 2021
This was referenced Jun 6, 2021
Open
Open
This was referenced Jun 6, 2021
1 task
This was referenced Jul 20, 2021
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR migrating v4
native-stackto TS 🎉Many options available in v4
native-stackare taken fromstack-navigator, they are included inStackNavigatorOptionsandNativeStackNavigationConfigtypes. There is also a type that is not used in v5native-stackand gives an option to useHeaderBackButtonfromreact-navigation-stack, it is calledBackButtonProps.Some of the props used for
HeaderBackButtonhave been changed because the former props didn't match the actual props fromHeaderBackButton. We keep the former props for backwards compatibility. Changed props are:backButtonTitle: resolves tolabelinstead oftitle,truncatedBackButtonTitle: resolves totruncatedLabelinstead oftruncatedTitle,backTitleVisible: resolves tolabelVisibleinstead ofbackTitleVisible,headerBackTitleStyle: resolves tolabelStyleinstead oftitleStyle,layoutPreset: resolves totitleLayoutinstead oflayoutPreset,scenewas removedChanges
Changed
createNativeStackNavigatorto TS.Added proper
typesfields inpackage.jsons.Changed
Test765to TS inTestsExampleproject.Testing changes
Test765.jsxinTestsExampleproject.Checklist