fix(iOS, Stack): delay setting navigation bar visibility to mitigate bar button bug on iOS 26 #3422
+117
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0maboro
approved these changes
Nov 26, 2025
kmichalikk
approved these changes
Nov 26, 2025
kkafar
reviewed
Nov 27, 2025
ios/RNSScreenStackHeaderConfig.mm
Outdated
| navitem.title = config.title; | ||
|
|
||
| // Setting navigation bar visibility is split to mitigate iOS 26 bug with bar button items. | ||
| [navctr setNavigationBarHidden:shouldHide animated:animated]; |
Member
There was a problem hiding this comment.
pass explicitly YES here, and NO in the other palce
Member
There was a problem hiding this comment.
You might even add assertion in the other place, that the shouldHide == NO, as we expect to return here early, when it is true.
kligarski
force-pushed
the
@kligarski/fix-order-of-header-configuration
branch
from
53ffd95 to
19f51d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves setting navigation bar visibility to the end of header configuration (after bar button items are setup) to mitigate bug on iOS 26 with bar button items being set after a delay.
before3422.mov
after3422.mov
Closes react-navigation/react-navigation#12844.
Closes https://github.com/software-mansion/react-native-screens-labs/issues/560.
Changes
Test code and steps to reproduce
Run
Test3422.Checklist