Implement shouldBeRequiredByOthersToFail #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsheyanov
added a commit
to vsheyanov/react-native-gesture-handler
that referenced
this pull request
Apr 1, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request introduce one new parameter that can be used across all gesture handlers – shouldBeRequiredByOthersToFail
It can be used to make other gesture handlers to hold off with recognising configured gestures for the handler marked with that flag. Unless that handler makes the decision other handlers won't switch into an "active" state.
To support this feature there is some major refactoring of the orchestrator code as well as a new state has been introduced (END) that can be now used to mark gesture handler as being finished but without immediately switching to UNDETERMINED state.