Fix interactions with NativeViewGestureHandler #1034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose `NativeViewGestureHandler ._handlerTag` on `ref` to enable interaction configuration.
Closed
|
@jakub-gonet any plans on merging this? |
|
#963 Originally posted by @ShaMan123 in #963 (comment) |
jgonet
reviewed
Nov 9, 2020
|
updated description |
jgonet
approved these changes
Nov 25, 2020
This was referenced Nov 25, 2020
|
Would be nice to have this in a release :) |
braincore
pushed a commit
to braincore/react-native-gesture-handler
that referenced
this pull request
Mar 4, 2021
### Context [`transformIntoHandlerTags`](https://github.com/software-mansion/react-native-gesture-handler/blob/master/createHandler.js#L91) creates an array of valid refs based on the value of the property `_handlerTag` of each ref passed to `waitFor` or `simultaneousHandlers` prop. The filtered array is then sent to native for configuration. ### `NativeViewGestureHandler` In the case of `NativeViewGestureHandler` the `_handlerTag` is set on the `NativeViewGestureHandler` ref properly. **HOWEVER**, this value isn't passed to the ref of it's child. The child's ref is the one being passed back as the ref handler of the component. This makes sense. **However**, in order to configure interactions on a different handler one would need to pass the `NativeViewGestureHandler` ref as part of `waitFor` or `simultaneousHandlers` prop. This is **IMPOSSIBLE** because the `NativeViewGestureHandler` ref isn't exposed. The child's ref is passed instead and is filtered out by `transformIntoHandlerTags` due to the lack of `_handlerTag` property, making it completely useless. ### The End This PR fixes the mentioned problem by setting the `_handlerTag` property on the `NativeViewGestureHandler` **child's ref** so when it is passed to `waitFor` or `simultaneousHandlers` it is treated as if it were a genuine gesture handler. Co-authored-by: Jakub <[email protected]>
|
Can someone provide a code example of how to use this? I am still having trouble with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
transformIntoHandlerTagscreates an array of valid refs based on the value of the property_handlerTagof each ref passed towaitFororsimultaneousHandlersprop. The filtered array is then sent to native for configuration.NativeViewGestureHandlerIn the case of
NativeViewGestureHandlerthe_handlerTagis set on theNativeViewGestureHandlerref properly.HOWEVER, this value isn't passed to the ref of it's child. The child's ref is the one being passed back as the ref handler of the component. This makes sense.
However, in order to configure interactions on a different handler one would need to pass the
NativeViewGestureHandlerref as part ofwaitFororsimultaneousHandlersprop.This is IMPOSSIBLE because the
NativeViewGestureHandlerref isn't exposed.The child's ref is passed instead and is filtered out by
transformIntoHandlerTagsdue to the lack of_handlerTagproperty, making it completely useless.The End
This PR fixes the mentioned problem by setting the
_handlerTagproperty on theNativeViewGestureHandlerchild's ref so when it is passed towaitFororsimultaneousHandlersit is treated as if it were a genuine gesture handler.