Skip to content

Snow-2226057: remove password from unload tests - migrate to key-pair #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 25, 2025
Merged

Snow-2226057: remove password from unload tests - migrate to key-pair #2502

merged 2 commits into from
Aug 25, 2025

Conversation

@sfc-gh-fpawlowski
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

  4. (Optional) PR for stored-proc connector:

@sfc-gh-fpawlowski sfc-gh-fpawlowski self-assigned this Aug 25, 2025
@sfc-gh-fpawlowski sfc-gh-fpawlowski requested a review from a team as a code owner August 25, 2025 10:25
@sfc-gh-fpawlowski sfc-gh-fpawlowski added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector labels Aug 25, 2025
@sfc-gh-fpawlowski sfc-gh-fpawlowski merged commit 7985a5f into main Aug 25, 2025
176 of 192 checks passed
@sfc-gh-fpawlowski sfc-gh-fpawlowski deleted the SNOW-2226057-remove-password-from-unload-tests branch August 25, 2025 16:04
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-snoonan sfc-gh-snoonan sfc-gh-snoonan approved these changes

Assignees

@sfc-gh-fpawlowski sfc-gh-fpawlowski

Labels

DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sfc-gh-fpawlowski @sfc-gh-snoonan