Skip to content

Conversation

@crokita
Copy link
Contributor

@crokita crokita commented Jun 2, 2021

Fixes #454

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have verified that this PR passes lint validation
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

Matches the Java library tests for this class in its state on the develop branch.

Summary

Adds operational classes and refactors the SoftButtonManager to use asynchronous task queues.

Additional Changes

  • Added extra validation methods for tests
  • SoftButtonState now has a default system action
  • SoftButtonObject will report if attempting to transition when there's only one state
  • SdlArtwork will not perform an action if the value passed to setType is undefined (for SoftButtonObject cloning purposes)

Copy link
Contributor

@renonick87 renonick87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See minor feedback.

@crokita crokita merged commit bc4906d into develop Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor SoftButtonManager to use Queues

3 participants