-
Notifications
You must be signed in to change notification settings - Fork 12
Fix manager to not delete and set identical voice commands #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix manager to not delete and set identical voice commands #438
Conversation
crokita
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See minor feedback
lib/js/src/manager/screen/utils/_VoiceCommandUpdateOperation.js
Outdated
Show resolved
Hide resolved
…al-voice-commands
…update unit tests
|
Updates made since last review:
|
crokita
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See feedback
| * @param {VoiceCommand[]} secondArray - an array of VoiceCommands | ||
| * @returns {VoiceCommand[]} - An array of VoiceCommands that are in the first array but not the second array | ||
| */ | ||
| _voiceCommandsNotInSecondArray (firstArray, secondArray) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could fail if either oldVoiceCommands or pendingVoiceCommands is null. Recommend null checking them
crokita
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See feedback
lib/js/src/manager/screen/utils/_VoiceCommandUpdateOperation.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris <[email protected]>
Fixes #433
Risk
This PR makes minor API changes.
Testing Plan
Unit Tests
Added unit tests to verify that VoiceCommands are added/deleted correctly.
Changelog
Bug Fixes
CLA