Skip to content

Align Keyboard Listener #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 30, 2021
Merged

Align Keyboard Listener #420

merged 3 commits into from
Mar 30, 2021

Conversation

@renonick87
Copy link
Contributor

@renonick87 renonick87 commented Mar 29, 2021

Fixes #419

Risk

This PR makes minor API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have verified that this PR passes lint validation
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Core Tests

Tested against the latest sdl_core build from the develop branch. Need to give Keyboard permissions in the policy table.

Bug Fixes

Fixes an alignment issue with the KeyboardListener. onKeyboardInputMaskHasChanged is now OnKeyboardDidUpdateInputMask.

CLA

@renonick87 renonick87 changed the base branch from develop to release/1.3.0_RC March 29, 2021 16:16
@crokita crokita changed the title Allign Keyboard Listener Align Keyboard Listener Mar 29, 2021
@renonick87 renonick87 merged commit 7a2581a into release/1.3.0_RC Mar 30, 2021
@renonick87 renonick87 mentioned this pull request Mar 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crokita crokita crokita approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

KeyboardListener method for InputMask is misaligned

3 participants

@renonick87 @crokita