Fix setting choice set timeouts #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renonick87
approved these changes
Mar 9, 2021
Contributor
Author
|
New changes needed for AlertView to align with ChoiceSet. Changes are based on the iOS equivalent class AlertView - https://github.com/smartdevicelink/sdl_ios/blob/develop/SmartDeviceLink/public/SDLAlertView.m |
renonick87
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #396
Risk
This PR makes no API changes. (Choice Set is not part of an official release yet)
Testing Plan
Unit Tests
Includes tests to check sanitization of timeout values
Summary
Adds better checks to setting and getting the choice set timeouts. Also includes a missing default timeout parameter in the choice set class and adds tests for those. Timeout values will now behave well when attempting to get their values.