Skip to content

[SDL 0269] New vehicle data ClimateData #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 10, 2021
Merged

[SDL 0269] New vehicle data ClimateData #350

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a74af69
feature/sdl_0269_new_vehicle_data_climateData
vladmu Nov 18, 2020
d1e6617
Review fixes
vladmu Nov 25, 2020
3881d93
Review fixes
vladmu Nov 25, 2020
9f8ba10
Merge remote-tracking branch 'origin/develop' into feature/sdl_0269_n…
vladmu Dec 15, 2020
f683c5c
Merge remote-tracking branch 'origin/develop' into feature/sdl_0269_n…
vladmu Jan 26, 2021
f3c57cb
regenerated RPCs
vladmu Jan 26, 2021
f71de8c
review fixes
vladmu Jan 26, 2021
29ece49
Merge remote-tracking branch 'origin/develop' into feature/sdl_0269_n…
BogMW Feb 1, 2021
e8316c2
Merge remote-tracking branch 'origin/develop' into feature/sdl_0269_n…
BogMW Feb 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/js/src/rpc/enums/VehicleDataType.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,15 @@ class VehicleDataType extends Enum {
return VehicleDataType._MAP.VEHICLEDATA_FUELCONSUMPTION;
}

/**
* Get the enum value for VEHICLEDATA_CLIMATEDATA.
* @since SmartDeviceLink 7.1.0
* @returns {String} - The enum value.
*/
static get VEHICLEDATA_CLIMATEDATA () {
return VehicleDataType._MAP.VEHICLEDATA_CLIMATEDATA;
}

/**
Copy link

@santhanamk santhanamk Nov 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to apply this history tag to VEHICLEDATA_EXTERNTEMP?

<history> <element name="VEHICLEDATA_EXTERNTEMP" since="2.0" until="X.x" /> </history>

I think you may just need to add * @since SmartDeviceLink 2.0.0 * @deprecated in SmartDeviceLink 7.1.0

around line 110 above static get VEHICLEDATA_EXTERNTEMP ().

Copy link
Contributor Author

@vladmu vladmu Nov 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible, but I'm not sure we need to add something here manually. The code you see is a result of the code generator tool.

* Get the enum value for VEHICLEDATA_EXTERNTEMP.
* @returns {String} - The enum value.
Expand Down Expand Up @@ -381,6 +390,7 @@ VehicleDataType._MAP = Object.freeze({
'VEHICLEDATA_FUELLEVEL': 'VEHICLEDATA_FUELLEVEL',
'VEHICLEDATA_FUELLEVEL_STATE': 'VEHICLEDATA_FUELLEVEL_STATE',
'VEHICLEDATA_FUELCONSUMPTION': 'VEHICLEDATA_FUELCONSUMPTION',
'VEHICLEDATA_CLIMATEDATA': 'VEHICLEDATA_CLIMATEDATA',
'VEHICLEDATA_EXTERNTEMP': 'VEHICLEDATA_EXTERNTEMP',
'VEHICLEDATA_VIN': 'VEHICLEDATA_VIN',
'VEHICLEDATA_GEARSTATUS': 'VEHICLEDATA_GEARSTATUS',
Expand Down
24 changes: 23 additions & 1 deletion lib/js/src/rpc/messages/GetVehicleData.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,30 @@ class GetVehicleData extends RpcRequest {
return this.getParameter(GetVehicleData.KEY_FUEL_RANGE);
}

/**
* Set the ClimateData
* @since SmartDeviceLink 7.1.0
* @param {Boolean} data - See ClimateData - The desired ClimateData.
* @returns {GetVehicleData} - The class instance for method chaining.
*/
setClimateData (data) {
this.setParameter(GetVehicleData.KEY_CLIMATE_DATA, data);
return this;
}

/**
* Get the ClimateData
* @returns {Boolean} - the KEY_CLIMATE_DATA value
*/
getClimateData () {
return this.getParameter(GetVehicleData.KEY_CLIMATE_DATA);
}

/**
* Set the ExternalTemperature
* @param {Boolean} temperature - The external temperature in degrees celsius - The desired ExternalTemperature.
* @since SmartDeviceLink 2.0.0
* @deprecated in SmartDeviceLink 7.1.0
* @param {Boolean} temperature - The external temperature in degrees celsius. This parameter is deprecated starting RPC Spec 7.1, please see climateData. - The desired ExternalTemperature.
* @returns {GetVehicleData} - The class instance for method chaining.
*/
setExternalTemperature (temperature) {
Expand Down Expand Up @@ -708,6 +729,7 @@ GetVehicleData.KEY_FUEL_LEVEL = 'fuelLevel';
GetVehicleData.KEY_FUEL_LEVEL_STATE = 'fuelLevel_State';
GetVehicleData.KEY_INSTANT_FUEL_CONSUMPTION = 'instantFuelConsumption';
GetVehicleData.KEY_FUEL_RANGE = 'fuelRange';
GetVehicleData.KEY_CLIMATE_DATA = 'climateData';
GetVehicleData.KEY_EXTERNAL_TEMPERATURE = 'externalTemperature';
GetVehicleData.KEY_TURN_SIGNAL = 'turnSignal';
GetVehicleData.KEY_VIN = 'vin';
Expand Down
26 changes: 25 additions & 1 deletion lib/js/src/rpc/messages/GetVehicleDataResponse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import { AirbagStatus } from '../structs/AirbagStatus.js';
import { BeltStatus } from '../structs/BeltStatus.js';
import { BodyInformation } from '../structs/BodyInformation.js';
import { ClimateData } from '../structs/ClimateData.js';
import { ClusterModeStatus } from '../structs/ClusterModeStatus.js';
import { ComponentVolumeStatus } from '../enums/ComponentVolumeStatus.js';
import { DeviceStatus } from '../structs/DeviceStatus.js';
Expand Down Expand Up @@ -230,9 +231,31 @@ class GetVehicleDataResponse extends RpcResponse {
return this.getObject(FuelRange, GetVehicleDataResponse.KEY_FUEL_RANGE);
}

/**
* Set the ClimateData
* @since SmartDeviceLink 7.1.0
* @param {ClimateData} data - See ClimateData - The desired ClimateData.
* @returns {GetVehicleDataResponse} - The class instance for method chaining.
*/
setClimateData (data) {
this._validateType(ClimateData, data);
this.setParameter(GetVehicleDataResponse.KEY_CLIMATE_DATA, data);
return this;
}

/**
* Get the ClimateData
* @returns {ClimateData} - the KEY_CLIMATE_DATA value
*/
getClimateData () {
return this.getObject(ClimateData, GetVehicleDataResponse.KEY_CLIMATE_DATA);
}

/**
* Set the ExternalTemperature
* @param {Number} temperature - The external temperature in degrees celsius - The desired ExternalTemperature.
* @since SmartDeviceLink 2.0.0
* @deprecated in SmartDeviceLink 7.1.0
* @param {Number} temperature - The external temperature in degrees celsius. This parameter is deprecated starting RPC Spec 7.1, please see climateData. - The desired ExternalTemperature.
* {'num_min_value': -40.0, 'num_max_value': 100.0}
* @returns {GetVehicleDataResponse} - The class instance for method chaining.
*/
Expand Down Expand Up @@ -761,6 +784,7 @@ GetVehicleDataResponse.KEY_FUEL_LEVEL = 'fuelLevel';
GetVehicleDataResponse.KEY_FUEL_LEVEL_STATE = 'fuelLevel_State';
GetVehicleDataResponse.KEY_INSTANT_FUEL_CONSUMPTION = 'instantFuelConsumption';
GetVehicleDataResponse.KEY_FUEL_RANGE = 'fuelRange';
GetVehicleDataResponse.KEY_CLIMATE_DATA = 'climateData';
GetVehicleDataResponse.KEY_EXTERNAL_TEMPERATURE = 'externalTemperature';
GetVehicleDataResponse.KEY_TURN_SIGNAL = 'turnSignal';
GetVehicleDataResponse.KEY_VIN = 'vin';
Expand Down
26 changes: 25 additions & 1 deletion lib/js/src/rpc/messages/OnVehicleData.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import { AirbagStatus } from '../structs/AirbagStatus.js';
import { BeltStatus } from '../structs/BeltStatus.js';
import { BodyInformation } from '../structs/BodyInformation.js';
import { ClimateData } from '../structs/ClimateData.js';
import { ClusterModeStatus } from '../structs/ClusterModeStatus.js';
import { ComponentVolumeStatus } from '../enums/ComponentVolumeStatus.js';
import { DeviceStatus } from '../structs/DeviceStatus.js';
Expand Down Expand Up @@ -209,9 +210,31 @@ class OnVehicleData extends RpcNotification {
return this.getObject(FuelRange, OnVehicleData.KEY_FUEL_RANGE);
}

/**
* Set the ClimateData
* @since SmartDeviceLink 7.1.0
* @param {ClimateData} data - See ClimateData - The desired ClimateData.
* @returns {OnVehicleData} - The class instance for method chaining.
*/
setClimateData (data) {
this._validateType(ClimateData, data);
this.setParameter(OnVehicleData.KEY_CLIMATE_DATA, data);
return this;
}

/**
* Get the ClimateData
* @returns {ClimateData} - the KEY_CLIMATE_DATA value
*/
getClimateData () {
return this.getObject(ClimateData, OnVehicleData.KEY_CLIMATE_DATA);
}

/**
* Set the ExternalTemperature
* @param {Number} temperature - The external temperature in degrees celsius - The desired ExternalTemperature.
* @since SmartDeviceLink 2.0.0
* @deprecated in SmartDeviceLink 7.1.0
* @param {Number} temperature - The external temperature in degrees celsius. This parameter is deprecated starting RPC Spec 7.1, please see climateData. - The desired ExternalTemperature.
* {'num_min_value': -40.0, 'num_max_value': 100.0}
* @returns {OnVehicleData} - The class instance for method chaining.
*/
Expand Down Expand Up @@ -740,6 +763,7 @@ OnVehicleData.KEY_FUEL_LEVEL = 'fuelLevel';
OnVehicleData.KEY_FUEL_LEVEL_STATE = 'fuelLevel_State';
OnVehicleData.KEY_INSTANT_FUEL_CONSUMPTION = 'instantFuelConsumption';
OnVehicleData.KEY_FUEL_RANGE = 'fuelRange';
OnVehicleData.KEY_CLIMATE_DATA = 'climateData';
OnVehicleData.KEY_EXTERNAL_TEMPERATURE = 'externalTemperature';
OnVehicleData.KEY_TURN_SIGNAL = 'turnSignal';
OnVehicleData.KEY_VIN = 'vin';
Expand Down
24 changes: 23 additions & 1 deletion lib/js/src/rpc/messages/SubscribeVehicleData.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,30 @@ class SubscribeVehicleData extends RpcRequest {
return this.getParameter(SubscribeVehicleData.KEY_FUEL_RANGE);
}

/**
* Set the ClimateData
* @since SmartDeviceLink 7.1.0
* @param {Boolean} data - See ClimateData - The desired ClimateData.
* @returns {SubscribeVehicleData} - The class instance for method chaining.
*/
setClimateData (data) {
this.setParameter(SubscribeVehicleData.KEY_CLIMATE_DATA, data);
return this;
}

/**
* Get the ClimateData
* @returns {Boolean} - the KEY_CLIMATE_DATA value
*/
getClimateData () {
return this.getParameter(SubscribeVehicleData.KEY_CLIMATE_DATA);
}

/**
* Set the ExternalTemperature
* @param {Boolean} temperature - The external temperature in degrees celsius - The desired ExternalTemperature.
* @since SmartDeviceLink 2.0.0
* @deprecated in SmartDeviceLink 7.1.0
* @param {Boolean} temperature - The external temperature in degrees celsius. This parameter is deprecated starting RPC Spec 7.1, please see climateData. - The desired ExternalTemperature.
* @returns {SubscribeVehicleData} - The class instance for method chaining.
*/
setExternalTemperature (temperature) {
Expand Down Expand Up @@ -690,6 +711,7 @@ SubscribeVehicleData.KEY_FUEL_LEVEL = 'fuelLevel';
SubscribeVehicleData.KEY_FUEL_LEVEL_STATE = 'fuelLevel_State';
SubscribeVehicleData.KEY_INSTANT_FUEL_CONSUMPTION = 'instantFuelConsumption';
SubscribeVehicleData.KEY_FUEL_RANGE = 'fuelRange';
SubscribeVehicleData.KEY_CLIMATE_DATA = 'climateData';
SubscribeVehicleData.KEY_EXTERNAL_TEMPERATURE = 'externalTemperature';
SubscribeVehicleData.KEY_TURN_SIGNAL = 'turnSignal';
SubscribeVehicleData.KEY_GEAR_STATUS = 'gearStatus';
Expand Down
25 changes: 24 additions & 1 deletion lib/js/src/rpc/messages/SubscribeVehicleDataResponse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,31 @@ class SubscribeVehicleDataResponse extends RpcResponse {
return this.getObject(VehicleDataResult, SubscribeVehicleDataResponse.KEY_FUEL_RANGE);
}

/**
* Set the ClimateData
* @since SmartDeviceLink 7.1.0
* @param {VehicleDataResult} data - See ClimateData - The desired ClimateData.
* @returns {SubscribeVehicleDataResponse} - The class instance for method chaining.
*/
setClimateData (data) {
this._validateType(VehicleDataResult, data);
this.setParameter(SubscribeVehicleDataResponse.KEY_CLIMATE_DATA, data);
return this;
}

/**
* Get the ClimateData
* @returns {VehicleDataResult} - the KEY_CLIMATE_DATA value
*/
getClimateData () {
return this.getObject(VehicleDataResult, SubscribeVehicleDataResponse.KEY_CLIMATE_DATA);
}

/**
* Set the ExternalTemperature
* @param {VehicleDataResult} temperature - The external temperature in degrees celsius. - The desired ExternalTemperature.
* @since SmartDeviceLink 2.0.0
* @deprecated in SmartDeviceLink 7.1.0
* @param {VehicleDataResult} temperature - The external temperature in degrees celsius. This parameter is deprecated starting RPC Spec 7.1, please see climateData. - The desired ExternalTemperature.
* @returns {SubscribeVehicleDataResponse} - The class instance for method chaining.
*/
setExternalTemperature (temperature) {
Expand Down Expand Up @@ -721,6 +743,7 @@ SubscribeVehicleDataResponse.KEY_FUEL_LEVEL = 'fuelLevel';
SubscribeVehicleDataResponse.KEY_FUEL_LEVEL_STATE = 'fuelLevel_State';
SubscribeVehicleDataResponse.KEY_INSTANT_FUEL_CONSUMPTION = 'instantFuelConsumption';
SubscribeVehicleDataResponse.KEY_FUEL_RANGE = 'fuelRange';
SubscribeVehicleDataResponse.KEY_CLIMATE_DATA = 'climateData';
SubscribeVehicleDataResponse.KEY_EXTERNAL_TEMPERATURE = 'externalTemperature';
SubscribeVehicleDataResponse.KEY_TURN_SIGNAL = 'turnSignal';
SubscribeVehicleDataResponse.KEY_GEAR_STATUS = 'gearStatus';
Expand Down
24 changes: 23 additions & 1 deletion lib/js/src/rpc/messages/UnsubscribeVehicleData.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,30 @@ class UnsubscribeVehicleData extends RpcRequest {
return this.getParameter(UnsubscribeVehicleData.KEY_FUEL_RANGE);
}

/**
* Set the ClimateData
* @since SmartDeviceLink 7.1.0
* @param {Boolean} data - See ClimateData - The desired ClimateData.
* @returns {UnsubscribeVehicleData} - The class instance for method chaining.
*/
setClimateData (data) {
this.setParameter(UnsubscribeVehicleData.KEY_CLIMATE_DATA, data);
return this;
}

/**
* Get the ClimateData
* @returns {Boolean} - the KEY_CLIMATE_DATA value
*/
getClimateData () {
return this.getParameter(UnsubscribeVehicleData.KEY_CLIMATE_DATA);
}

/**
* Set the ExternalTemperature
* @param {Boolean} temperature - The external temperature in degrees celsius. - The desired ExternalTemperature.
* @since SmartDeviceLink 2.0.0
* @deprecated in SmartDeviceLink 7.1.0
* @param {Boolean} temperature - The external temperature in degrees celsius. This parameter is deprecated starting RPC Spec 7.1, please see climateData. - The desired ExternalTemperature.
* @returns {UnsubscribeVehicleData} - The class instance for method chaining.
*/
setExternalTemperature (temperature) {
Expand Down Expand Up @@ -690,6 +711,7 @@ UnsubscribeVehicleData.KEY_FUEL_LEVEL = 'fuelLevel';
UnsubscribeVehicleData.KEY_FUEL_LEVEL_STATE = 'fuelLevel_State';
UnsubscribeVehicleData.KEY_INSTANT_FUEL_CONSUMPTION = 'instantFuelConsumption';
UnsubscribeVehicleData.KEY_FUEL_RANGE = 'fuelRange';
UnsubscribeVehicleData.KEY_CLIMATE_DATA = 'climateData';
UnsubscribeVehicleData.KEY_EXTERNAL_TEMPERATURE = 'externalTemperature';
UnsubscribeVehicleData.KEY_TURN_SIGNAL = 'turnSignal';
UnsubscribeVehicleData.KEY_GEAR_STATUS = 'gearStatus';
Expand Down
25 changes: 24 additions & 1 deletion lib/js/src/rpc/messages/UnsubscribeVehicleDataResponse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,31 @@ class UnsubscribeVehicleDataResponse extends RpcResponse {
return this.getObject(VehicleDataResult, UnsubscribeVehicleDataResponse.KEY_FUEL_RANGE);
}

/**
* Set the ClimateData
* @since SmartDeviceLink 7.1.0
* @param {VehicleDataResult} data - See ClimateData - The desired ClimateData.
* @returns {UnsubscribeVehicleDataResponse} - The class instance for method chaining.
*/
setClimateData (data) {
this._validateType(VehicleDataResult, data);
this.setParameter(UnsubscribeVehicleDataResponse.KEY_CLIMATE_DATA, data);
return this;
}

/**
* Get the ClimateData
* @returns {VehicleDataResult} - the KEY_CLIMATE_DATA value
*/
getClimateData () {
return this.getObject(VehicleDataResult, UnsubscribeVehicleDataResponse.KEY_CLIMATE_DATA);
}

/**
* Set the ExternalTemperature
* @param {VehicleDataResult} temperature - The external temperature in degrees celsius - The desired ExternalTemperature.
* @since SmartDeviceLink 2.0.0
* @deprecated in SmartDeviceLink 7.1.0
* @param {VehicleDataResult} temperature - The external temperature in degrees celsius. This parameter is deprecated starting RPC Spec 7.1, please see climateData. - The desired ExternalTemperature.
* @returns {UnsubscribeVehicleDataResponse} - The class instance for method chaining.
*/
setExternalTemperature (temperature) {
Expand Down Expand Up @@ -721,6 +743,7 @@ UnsubscribeVehicleDataResponse.KEY_FUEL_LEVEL = 'fuelLevel';
UnsubscribeVehicleDataResponse.KEY_FUEL_LEVEL_STATE = 'fuelLevel_State';
UnsubscribeVehicleDataResponse.KEY_INSTANT_FUEL_CONSUMPTION = 'instantFuelConsumption';
UnsubscribeVehicleDataResponse.KEY_FUEL_RANGE = 'fuelRange';
UnsubscribeVehicleDataResponse.KEY_CLIMATE_DATA = 'climateData';
UnsubscribeVehicleDataResponse.KEY_EXTERNAL_TEMPERATURE = 'externalTemperature';
UnsubscribeVehicleDataResponse.KEY_TURN_SIGNAL = 'turnSignal';
UnsubscribeVehicleDataResponse.KEY_GEAR_STATUS = 'gearStatus';
Expand Down
Loading