Release 5.5.0 #1816
Merged
Release 5.5.0 #1816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* check isGraphicSupported in SoftButtonManager * Remove log from testing * fix formatting * Unit test updates * Add unit test to test when graphic is not supported. Align with iOS on uploading graphic when no capability is retrieved * Fix logic to allow for static images to still be uploaded if dynamic are not supported * Fix logic in uploading softbuttons, align with iOS * Revert log back to a warning * Add unit test * Refactor isGraphicSupported to isDynamicGraphicSupported
Codecov Report
@@ Coverage Diff @@
## master #1816 +/- ##
============================================
+ Coverage 54.02% 54.07% +0.04%
- Complexity 5522 5534 +12
============================================
Files 562 562
Lines 25757 25809 +52
Branches 3382 3395 +13
============================================
+ Hits 13916 13955 +39
- Misses 10577 10583 +6
- Partials 1264 1271 +7
|
noah-livio
approved these changes
Jun 21, 2022
Co-authored-by: noah-livio <[email protected]>
…on.java Co-authored-by: noah-livio <[email protected]>
…on.java Co-authored-by: noah-livio <[email protected]>
…on.java Co-authored-by: noah-livio <[email protected]>
…on.java Co-authored-by: noah-livio <[email protected]>
noah-livio
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.5.0
This PR is [ready] for review.
Risk
This PR makes [minor] API changes.
Testing Plan
Summary
See the 5.5.0 Project
CLA