[Accepted with Revisions] SDL 0293 Revisions - Enable OEM exclusive apps support

[jordynmackool]

Hello SDL community,

The review of "Revise SDL-0293 Enable OEM exclusive apps support" began on December 15, 2020, and continues through January 26, 2021.

This will be a review of proposed revisions to a previously accepted but not yet implemented proposal, SDL 0293.

The pull request outlining the revisions under review is available here:

#1106

Reviews are an important part of the SDL evolution process. All reviews should be sent to the associated Github issue at:

#1108

What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:

• Is the problem being addressed significant enough to warrant a change to SDL?
• Does this proposal fit well with the feel and direction of SDL?
• If you have used competitors with a similar feature, how do you feel that this proposal compares to those?
• How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
  Please state explicitly whether you believe that the proposal should be accepted into SDL.

More information about the SDL evolution process is available at

https://github.com/smartdevicelink/sdl_evolution/blob/master/process.md

Thank you,
Jordyn Mackool

Program Manager - Livio
jordyn@livio.io

[vladmu]

Hello SDL community,

I have a point regarding the proposed changes because I see some data inconsistency in the way proposed here. The systemHardwareVersion parameter looks very similar to the systemSoftwareVersion which was not placed in the VehicleType structure but is a separate parameter in the RegisterAppInterfaceResponse and the GetSystemInfo HMI's function. So my concern is that in the proposed revision the systemHardwareVersion is a part of the VehicleType and is not implemented in the same way as the systemSoftwareVersion, otherwise, we need the last one to be implemented in the same way as the systemHardwareVersion proposed here and put it into the VehicleType structure also to match "send it to the mobile criteria".

[vladmu]

Hello SDL community,

The comment above is not actual anymore because the latest commit contains described changes.

[jordynmackool]

The author has added additional commits to the pull request which changes what was under review. Since changes were made to the PR, we must immediately withdraw this and lock it. We will discuss if we can bring it back into review during the next Steering Committee Meeting.