Skip to content

Fix UnregisterAppInterface for not found app #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix UnregisterAppInterface for not found app #1572

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de69dfe
Fix UnregisterAppInterface for not found app
May 29, 2017
0e2707b
Add Unit Test
May 29, 2017
cb7f7b9
Change comparison
May 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/components/application_manager/src/commands/command_request_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,9 +487,11 @@ mobile_apis::Result::eType CommandRequestImpl::GetMobileResultCode(
bool CommandRequestImpl::CheckAllowedParameters() {
LOG4CXX_AUTO_TRACE(logger_);

// RegisterAppInterface should always be allowed
if (mobile_apis::FunctionID::RegisterAppInterfaceID ==
static_cast<mobile_apis::FunctionID::eType>(function_id())) {
// RegisterAppInterface and UnregisterAppInterface should always be allowed
const mobile_apis::FunctionID::eType func_id =
static_cast<mobile_apis::FunctionID::eType>(function_id());
if (mobile_apis::FunctionID::RegisterAppInterfaceID == func_id ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvvasilev I propose you to use helpers::Compare here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AKalinich-Luxoft Done in cb7f7b9

mobile_apis::FunctionID::UnregisterAppInterfaceID == func_id) {
return true;
}

Expand Down
20 changes: 20 additions & 0 deletions src/components/application_manager/test/commands/command_request_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,26 @@ TEST_F(CommandRequestImplTest,
(*result)[strings::msg_params][strings::info].asString().empty());
}

TEST_F(CommandRequestImplTest, CheckPermissions_UnregisterAppInterface_True) {
MessageSharedPtr msg = CreateMessage();
(*msg)[strings::params][strings::function_id] =
mobile_apis::FunctionID::UnregisterAppInterfaceID;

CommandPtr command = CreateCommand<UCommandRequestImpl>(msg);

EXPECT_TRUE(command->CheckPermissions());
}

TEST_F(CommandRequestImplTest, CheckPermissions_RegisterAppInterface_True) {
MessageSharedPtr msg = CreateMessage();
(*msg)[strings::params][strings::function_id] =
mobile_apis::FunctionID::RegisterAppInterfaceID;

CommandPtr command = CreateCommand<UCommandRequestImpl>(msg);

EXPECT_TRUE(command->CheckPermissions());
}

} // namespace command_request_impl
} // namespace commands_test
} // namespace components
Expand Down