Do not remove true/false phpdoc if type hint is bool #1778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good but tests are missing. |
|
Tests need to be version specific, since transformation of bool/true depends on the php_version in phpcs config. Waiting for reply of #1776 (comment) so I know how/what tests to add specifically |
Tests should depend only on the value of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1777
No tests added yet, bc adding them would cause conflicts with the other one of my PRs. Feel free to just copy the test case provided in the issue as a unit test yourself or I'll do it once the other PR is merged (and I can rebase this one)