-
Notifications
You must be signed in to change notification settings - Fork 8
Check for sinol-make updates when running #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
How does it work when there is no internet connection or it is very slow? In such cases, we shouldn't annoy the user in any way. |
|
When there’s no internet the code will work well, but I haven’t thought about slow connections |
|
I added a one second timeout for the request, I think it's the best solution for slow networks |
|
Can this be reduced to e.g. 0.3s? We should be as non-invasive as possible. In fact, if it's possible to cache when we have last checked for updates, it would be even better, instead of executing it on each |
|
Now the check is version check is running asynchronously |
tonowak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I ask to add a few more comments? It's not immediately obvious what the new code does, what is being done concurrently, why do we have a new directory, what are possible orders of executions.
|
Can we add tests? I want to be sure that the warning isn't printed when it shouldn't be printed and the code doesn't crash. So we could e.g. test the code when there is no internet connection, or with different release versions (that would require somehow changing the link or the behavior, so that testing it will be possible). |
Co-authored-by: Tomasz Nowak <[email protected]>
No description provided.