Skip to content

Conversation

@dlachasse
Copy link

Description of change

This adds the login attribute of the stargazers response object to the Stargazers schema.

Manual QA steps

  • I ran the tap locally to ensure this was working as expected:
$ tap-github --config config.json --properties properties.json
{"type": "STATE", "value": {}}
INFO Starting sync of repository: wandb/local
{"type": "SCHEMA", "stream": "stargazers", "schema": {"selected": true, "type": ["null", "object"], "additionalProperties": false, "properties": {"_sdc_repository": {"type": ["string"]}, "user": {"type": ["null", "object"], "additionalProperties": false, "properties": {"id": {"type": ["null", "integer"]}}}, "starred_at": {"type": ["null", "string"], "format": "date-time"}, "user_id": {"type": ["null", "integer"]}, "login": {"type": ["null", "string"]}}}, "key_properties": ["user_id"]}
INFO METRIC: {"type": "timer", "metric": "http_request_duration", "value": 0.396655797958374, "tags": {"endpoint": "stargazers", "http_status_code": 200, "status": "succeeded"}}
{"type": "RECORD", "stream": "stargazers", "record": {"starred_at": "2020-10-22T17:18:25.000000Z", "user": {"id": 6808929}, "_sdc_repository": "wandb/local", "user_id": 6808929, "login": "szelenka"}, "time_extracted": "2022-06-29T21:57:16.074995Z"}
{"type": "RECORD", "stream": "stargazers", "record": {"starred_at": "2020-10-22T17:22:57.000000Z", "user": {"id": 7882515}, "_sdc_repository": "wandb/local", "user_id": 7882515, "login": "dmeyer3691"}, "time_extracted": "2022-06-29T21:57:16.074995Z"}

Risks

  • Since this is only adding an attribute and not changing the granularity of the report this should be low-risk.

Rollback steps

  • revert this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant