Add Flow globals #307
Open
Add Flow globals #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
address style issues add missing ReadOnlyArray
mightyaleksey
force-pushed
the
flow_support
branch
from
4822f10 to
1c08513
Compare
sindresorhus
approved these changes
Oct 29, 2025
fisker
reviewed
Oct 29, 2025
| - utilities: https://flow.org/en/docs/types/utilities/ | ||
| */ | ||
| export default { | ||
| $Exact: false, |
There was a problem hiding this comment.
This seems like a type utility, is this needed to lint flow files?
Does typescript-eslint provide similar things? I didn't see in typescript-eslint code base.
//cc @sindresorhus
There was a problem hiding this comment.
I didn't see these in hermes-eslint either.
static_h is their dev branch.
There was a problem hiding this comment.
Most of those functions are utility functions. Here is Exact https://flow.org/en/docs/types/utilities/#toc-exact. I think most common ones are $Keys and $Values.
As far as I remember with one of the updates, flow made all objects exact by default making this utility unnecessary.
There was a problem hiding this comment.
Question is, they are for types, you can't use as value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, since the globals package is commonly used by linters (eslint, standard) to set up global variables for particular environment, I thought that it would be nice to add support for the flow type system.
This PR creates
flowenvironment and adds the following globals: