Generate the static file hashes at app startup, rather than requiring a build stage #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelson
commented
Jun 16, 2025
pelson
commented
Jun 16, 2025
pelson
commented
Jun 16, 2025
pelson
commented
Jun 16, 2025
Contributor
Author
pelson
left a comment
pelson
left a comment
There was a problem hiding this comment.
Would be good to have strict type checking enabled.
pelson
force-pushed
the
feature/static-files-at-runtime
branch
from
79dcebe to
ab5b0bd
Compare
pelson
force-pushed
the
feature/static-files-at-runtime
branch
from
ab5b0bd to
6bac7ac
Compare
Contributor
Author
|
Would be good to get this to work in develop mode (especially if running outside of simple-repository-browser itself) |
pelson
commented
Jun 16, 2025
| @@ -1,17 +1,18 @@ | |||
| # from __future__ import annotations | |||
Contributor
Author
There was a problem hiding this comment.
Wasn't able to enable this - it results in a broken fastapi app
pelson
force-pushed
the
feature/static-files-at-runtime
branch
from
518a1a6 to
d533c2d
Compare
pelson
force-pushed
the
feature/static-files-at-runtime
branch
from
d533c2d to
5ac15e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.