Skip to content

Make metadata retrieval issues show up in the description, rather than elsewhere #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2025
Merged

Make metadata retrieval issues show up in the description, rather than elsewhere #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions simple_repository_browser/fetch_description.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,10 +156,10 @@ def _create_files_info_mapping(


class MinimalDistribution(pkginfo.Distribution):
def __init__(self, name: str, summary: str):
def __init__(self, name: str, description: str):
super().__init__() # Get all the default None values
self.name = name
self.summary = summary
self.description = description


async def _fetch_metadata_resource(
Expand All @@ -174,7 +174,7 @@ async def _fetch_metadata_resource(
# Return a minimal distribution object with basic info
ext = file.filename.rsplit(".", 1)[-1]
reason = f"Legacy package format ({ext}) - metadata not available"
minimal_dist = MinimalDistribution(project_name, summary=reason)
minimal_dist = MinimalDistribution(project_name, description=reason)
return file, minimal_dist

resource_name = file.filename + ".metadata"
Expand All @@ -185,7 +185,7 @@ async def _fetch_metadata_resource(
resource = await repository.get_resource(project_name, resource_name)
except simple_repository.errors.ResourceUnavailable as err:
reason = f"Unable to retrieve metadata for {file.filename} ({err})"
minimal_dist = MinimalDistribution(project_name, summary=reason)
minimal_dist = MinimalDistribution(project_name, description=reason)
logging.exception(reason)
return file, minimal_dist

Expand Down