Implement setters #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkurdek
reviewed
Apr 8, 2024
| { | ||
| public string PropertyName => MemberName; | ||
| public bool IsConditional => false; | ||
| public string? PropertyName => MemberName; |
Collaborator
There was a problem hiding this comment.
Im not sure about nullable string here. Now implementations of IPathPart do not share any functionality. It feels like IPathPart could be a class with enum.
Owner
Author
There was a problem hiding this comment.
yeah, we could just object[] Path and have a function to do pattern matching to get the property name... but I think we can leave that to some refactoring later (the interface might change again, even though we're getting close to a finish line)
Collaborator
There was a problem hiding this comment.
Sure, we can handle this later
jkurdek
approved these changes
Apr 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a lot more work than I thought it would be. It was hard to get it working with nested
Cast(ConditionalAccess(...))so I madeCastnon-nestable. That simplified things significantly.