Skip to content

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Oct 8, 2025

Fixes #779

I also took the opportunity to update DataFileService with some modern dotnet features (await using), and to clean up some of the formatting.


This change is Reviewable

@pmachapman pmachapman requested review from Enkidu93 and ddaspit October 8, 2025 23:49
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.10%. Comparing base (a3eee4b) to head (52ef516).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #787      +/-   ##
==========================================
- Coverage   66.13%   66.10%   -0.03%     
==========================================
  Files         370      370              
  Lines       20019    20012       -7     
  Branches     2617     2619       +2     
==========================================
- Hits        13239    13229      -10     
- Misses       5850     5852       +2     
- Partials      930      931       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@Enkidu93 Enkidu93 force-pushed the fix_data_file_deletion branch from e81b1ff to 52ef516 Compare October 10, 2025 18:55
@Enkidu93 Enkidu93 merged commit 058b782 into main Oct 10, 2025
3 checks passed
@Enkidu93 Enkidu93 deleted the fix_data_file_deletion branch October 10, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File not found error on production when fetching USFM

5 participants