Skip to content

Conversation

@Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Oct 2, 2025

Changes include:

  • Use new errorHandler and compareSegments parameters
  • Fix typo
  • Fix marker placement handler issues

Fixes #773, #770


This change is Reviewable

@Enkidu93 Enkidu93 requested a review from ddaspit October 2, 2025 19:48
Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@Enkidu93 Enkidu93 force-pushed the integrate_usfm_updater_changes branch from d9846b0 to 6496937 Compare October 3, 2025 15:01
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.12%. Comparing base (db2ac0a) to head (6496937).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #777   +/-   ##
=======================================
  Coverage   66.11%   66.12%           
=======================================
  Files         370      370           
  Lines       20018    20017    -1     
  Branches     2618     2616    -2     
=======================================
+ Hits        13235    13236    +1     
+ Misses       5852     5851    -1     
+ Partials      931      930    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Enkidu93 Enkidu93 merged commit 0f18e01 into main Oct 3, 2025
2 of 3 checks passed
@Enkidu93 Enkidu93 deleted the integrate_usfm_updater_changes branch October 3, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only use target convention for quotation denormalization

4 participants