-
-
Notifications
You must be signed in to change notification settings - Fork 3
Replaced SuppressMessage attributes with PublicAPI from JetBrains.Annotations #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…otations Deprecated AbandondedSuites in favor of correctly spelled AbandonedSuites Misc minor code refactoring and cleanup. Fixed typos in comments.
imnasnainaec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 15 of 26 files at r1, all commit messages.
Reviewable status: 15 of 26 files reviewed, all discussions resolved (waiting on @ermshiperete)
SIL.BuildTasks/FileUpdate.cs line 1 at r1 (raw file):
// Copyright (c) 2023 SIL Global
2023-2025
SIL.BuildTasks.AWS/S3/S3BuildPublisher.cs line 84 at r1 (raw file):
private bool ProcessFiles() { Log.LogMessage(MessageImportance.Normal, "Publishing SourceFiles={0} to {1}", Join(SourceFiles), DestinationBucket);
Is changing a log message possibly a breaking change?
SIL.BuildTasks/StampAssemblies/StampAssemblies.cs line 1 at r1 (raw file):
// Copyright (c) 2025 SIL Global
2018-2025
SIL.BuildTasks/UnitTestTasks/TestTask.cs line 1 at r1 (raw file):
// Copyright (c) 20218-2025 SIL Global
2018-2025
…-change in CHANGELOG
tombogle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 15 of 26 files reviewed, all discussions resolved (waiting on @ermshiperete)
SIL.BuildTasks.AWS/S3/S3BuildPublisher.cs line 84 at r1 (raw file):
Previously, imnasnainaec (D. Ror.) wrote…
Is changing a log message possibly a breaking change?
I did consider that possibility. I wouldn't think so, but I'm not sure how to verify for sure.
ermshiperete
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ermshiperete
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 22 of 26 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tombogle)
imnasnainaec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tombogle)
Also:
This change is