LT-19718: Replace Default WS in New Project Wizard #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonleenaylor
requested changes
May 16, 2019
Contributor
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
I think english needs to be preserved in the all list.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @papeh)
Src/FwCoreDlgs/FwCoreDlgsTests/FwNewLangProjectModelTests.cs, line 455 at r1 (raw file):
Assert.That(model.WritingSystemContainer.CurrentAnalysisWritingSystems.First().LanguageTag, Is.EqualTo("en"), "Test setup problem"); model.SetDefaultWs(new LanguageInfo{LanguageTag = "de"}); Assert.That(model.WritingSystemContainer.AnalysisWritingSystems.Count, Is.EqualTo(1), "all");
I expected to have english retained in the analysis list. If it is somehow added after the wizard we need a test for that.
- When selecting a new Default WS, relpace the existing one - Test that English is an Analysis WS in every new project, even if the user has removed it. Change-Id: I82c732cc40d9cd3d259002275b7eabcc55eff981
Contributor
Author
|
submitted and merged through Gerrit. |
sillsdevgerrit
pushed a commit
that referenced
this pull request
Nov 12, 2020
Includes: 1. Assimilating all IUtility implementations into the UtilityDlg class. 2. Make one version of the string "???" and have all clients use it. 3. Move code out of the IUtility impls and into FwUtils as extensions of LCM. 4. Move related tests for #3 into FwUtils test assembly. 5. Re-add support for user-defined IUtility impls. 6. Get rid of unused code (e.g., SampleCitationFormTransducer class). Change-Id: I38629bd5929d1fc8c1b851ac13212f4b4f5c69b6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I82c732cc40d9cd3d259002275b7eabcc55eff981
This change is