Skip to content

Update protobuf plugin #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Update protobuf plugin #185

merged 1 commit into from
Oct 18, 2022

Conversation

loosebazooka
Copy link
Member

Looks like the new protobuf plugin handles a few more things that the old one. Updates to remove unnecessary config that was breaking things.

Signed-off-by: Appu Goundan [email protected]

@loosebazooka loosebazooka requested review from vlsi and patflynn October 17, 2022 20:30
patflynn
patflynn previously approved these changes Oct 17, 2022
@loosebazooka
Copy link
Member Author

I think staging is going through something, I'll wait for it come back and run these tests again.

@vlsi
Copy link
Collaborator

vlsi commented Oct 18, 2022

@loosebazooka , thanks.
Please replace dependsOn("generateProto", "generateJsonSchema2DataClass0") with dependsOn("generateJsonSchema2DataClass0") at the end of /sigstore-java/build.gradle.kts.
It looks like dependsOn("generateProto") is no longer needed.

Signed-off-by: Appu Goundan <[email protected]>
@loosebazooka
Copy link
Member Author

@vlsi thanks for filing those protobuf gradle plugin bugs, I was also gonna see if they would update their kotlin-dsl example.

@loosebazooka loosebazooka merged commit 7883f72 into main Oct 18, 2022
@loosebazooka loosebazooka deleted the protobuf-update branch October 18, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants