Skip to content

Update dependency com.fasterxml.jackson.core:jackson-databind to v2.13.4 #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 10, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.fasterxml.jackson.core:jackson-databind (source) 2.13.3 -> 2.13.4 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/com.fasterxml.jackson.core-jackson-databind-2.x branch from 2da17bc to 012eae2 Compare September 10, 2022 13:01
@loosebazooka loosebazooka requested a review from vlsi September 12, 2022 17:45
@loosebazooka
Copy link
Member

@vlsi, okay to merge?

@vlsi vlsi merged commit 96707e0 into main Sep 15, 2022
@vlsi vlsi deleted the renovate/com.fasterxml.jackson.core-jackson-databind-2.x branch September 15, 2022 19:53
@vlsi
Copy link
Collaborator

vlsi commented Sep 15, 2022

Jackson was a poorman's way to create sigstore bundle.
I guess bundle creation should be moved from https://github.com/sigstore/sigstore-java/blob/main/sigstore-gradle/sigstore-gradle-sign-base-plugin/src/main/kotlin/dev/sigstore/sign/bundle/SigstoreBundle.kt to sigstore-java, however I'm not sure what would you suggest for building the json. Gson? Protobuf?

@loosebazooka
Copy link
Member

We already use gson, so we can continue using that. The bundle will be json formatted I believe.

@vlsi
Copy link
Collaborator

vlsi commented Sep 15, 2022

I mean we could use the official proto definition and use proto3 to json for the "canonical output"

@loosebazooka
Copy link
Member

oh I didn't know there was an official bundle proto?

@vlsi
Copy link
Collaborator

vlsi commented Sep 15, 2022

See specs/dotsigstore_bundle/pb/bundle.proto

https://github.com/sigstore/cosign/pull/2204/files#diff-0c949f5460747a137445ecd0069d02014cc93ab8210e1ec3588c87634d872865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants