Attestation processing optimization with batching #8285
+191
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eserilev
reviewed
Oct 24, 2025
michaelsproul
added
optimization
eserilev
reviewed
Oct 29, 2025
beacon_node/beacon_processor/src/scheduler/work_reprocessing_queue.rs
Outdated
Show resolved
Hide resolved
hopinheimer
changed the title
…hthouse into attestation-optimisation
eserilev
reviewed
Nov 3, 2025
beacon_node/beacon_processor/src/scheduler/work_reprocessing_queue.rs
Outdated
Show resolved
Hide resolved
dapplion
reviewed
Nov 10, 2025
| let mut attestations = GossipAttestationBatch::new(); | ||
| let mut iter = batch_attestation.0.into_iter(); | ||
|
|
||
| if let Some(first) = iter.next() { |
Collaborator
There was a problem hiding this comment.
Is it easier to read to do if !is_empty() { let first = batch_attestation.first().expect("not empty") }?
dapplion
reviewed
Nov 10, 2025
| pub const QUEUED_ATTESTATION_DELAY: Duration = Duration::from_secs(12); | ||
|
|
||
| /// Batched attestation delay. | ||
| pub const QUEUED_BATCH_ATTESTATION_DELAY: Duration = Duration::from_millis(50); |
Collaborator
There was a problem hiding this comment.
This must be a flag, and if set to 0 disable this mechanism. In case we observe propagation degradation have a way to turn it off. And upper bound the flag value to a reasonable value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8208
Current the implementation follows a naive approach of batching every 50ms, but I do have an idea for greedy batcher which I'll be implementing in following commits.