Improve block header signature handling #8253
Merged
+307
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
test improvement
|
Some required checks have failed. Could you please take a look @michaelsproul? 🙏 |
mergify
bot
added
waiting-on-author
jimmygchen
reviewed
Oct 21, 2025
jimmygchen
added a commit
that referenced
this pull request
Oct 21, 2025
Squashed commit of the following: commit 0cfde28 Author: Michael Sproul <[email protected]> Date: Tue Oct 21 17:15:47 2025 +1100 Use valid sidecars in SSE tests commit e181950 Author: Michael Sproul <[email protected]> Date: Tue Oct 21 16:56:31 2025 +1100 Set min blob count to 1 commit 697d2fe Author: Michael Sproul <[email protected]> Date: Tue Oct 21 15:37:20 2025 +1100 Add data column test commit a5ec707 Author: Michael Sproul <[email protected]> Date: Tue Oct 21 15:24:40 2025 +1100 Add test for RPC blobs
Merged
jimmygchen
removed
the
waiting-on-author
10 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
Open PRs to include for the release - #7907 - #8247 - #8251 - #8253 - #8254 - #8265 - #8269 - #8266 Co-Authored-By: Jimmy Chen <[email protected]> Co-Authored-By: Jimmy Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes:
Proposed Changes
Reject blob and data column sidecars from RPC with invalid signatures.
Additional Info
Two regression tests cover the simple cases. There are some more subtleties involving the events API, the slashing observation cache and the slasher which we could test in future. But these are less impactful.