Skip to content

fix: definePageMeta auth option type #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2023
Merged

fix: definePageMeta auth option type #398

merged 1 commit into from
May 18, 2023

Conversation

@mlutsiuk
Copy link
Contributor

@mlutsiuk mlutsiuk commented May 17, 2023

Closes #397.

Checklist:

  • issue number linked above after pound (#)
    • replace "Closes " with "Contributes to" or other if this PR does not close the issue
  • manually checked my feature / checking not applicable
  • wrote tests / testing not applicable
  • attached screenshots / screenshot not applicable

BracketJohn
BracketJohn approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@BracketJohn BracketJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks weitd, but let's try it out!

@BracketJohn BracketJohn merged commit d8cb190 into sidebase:main May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BracketJohn BracketJohn BracketJohn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

auth option of definePageMeta is not typed

2 participants

@mlutsiuk @BracketJohn