Refactor BinaryLogClient into an abstract base class to allow for more flexible use by sacundim · Pull Request #16 · shyiko/mysql-binlog-connector-java

Started refactoring the library to give the EventListener more control over whether to stop the BinaryLogClient.

ldcasillas-progreso

committed

Improved factoring:

ldcasillas-progreso

committed

Tiny bug in integration test: it didn't like the -0700 timezone.

ldcasillas-progreso

committed

Fix ConcurrentModificationException that I introduced.

ldcasillas-progreso

committed

Now passes checkstyle.

ldcasillas-progreso

committed

One of the serialization/deserialization test cases fails in the America/Los_Angeles timezone, because of Daylight Saving Time. I've added a comment to that effect.

ldcasillas-progreso

committed

Undo the BroadcastEventListener and BroadcastLifecycleListener refactor, since now it only serves to make the code longer.

ldcasillas-progreso

committed

Forgot to delete the BroadcastLifecycleListener.

ldcasillas-progreso

committed

Cosmetic changes to reduce diff noise for the pull request

ldcasillas-progreso

committed

more cosmetics

ldcasillas-progreso

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refactor BinaryLogClient into an abstract base class to allow for more flexible use#16

Refactor BinaryLogClient into an abstract base class to allow for more flexible use#16
sacundim wants to merge 10 commits intoshyiko:masterfrom
sacundim:master

Commits on Apr 18, 2014

Started refactoring the library to give the EventListener more control over whether to stop the BinaryLogClient.

Improved factoring:

Tiny bug in integration test: it didn't like the -0700 timezone.

Fix ConcurrentModificationException that I introduced.

Now passes checkstyle.

One of the serialization/deserialization test cases fails in the America/Los_Angeles timezone, because of Daylight Saving Time. I've added a comment to that effect.

Undo the BroadcastEventListener and BroadcastLifecycleListener refactor, since now it only serves to make the code longer.

Forgot to delete the BroadcastLifecycleListener.

Cosmetic changes to reduce diff noise for the pull request

more cosmetics

Refactor BinaryLogClient into an abstract base class to allow for more flexible use#16sacundim wants to merge 10 commits intoshyiko:mastershyiko/mysql-binlog-connector-java:masterfrom sacundim:mastersacundim/mysql-binlog-connector-java:masterCopy head branch name to clipboard

Commits

Commits on Apr 18, 2014

Refactor BinaryLogClient into an abstract base class to allow for more flexible use#16
sacundim wants to merge 10 commits intoshyiko:masterfrom
sacundim:master