This repository was archived by the owner on Dec 21, 2023. It is now read-only.
perf: imporve keyboard on iOS #1743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alantoa
requested review from
axeldelafosse and
intergalacticspacehighway
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PR Preview - StorybookThis pull request preview deployment is now available. ✅ Preview: exp+io.showtime.storybook://expo-development-client/?url=https://u.expo.dev/e77d5b68-bb27-45da-aa5c-96c1fdbf6706&channel-name=pr-1743 Comment ID: 1342424654 |
PR Preview - AppThis pull request preview deployment is now available. ✅ Preview: exp+io.showtime.development://expo-development-client/?url=https://u.expo.dev/45cbf5d5-24fe-4aa6-9580-acf540651abd&channel-name=pr-1743 Comment ID: 1342479165 |
PR Preview - Storybook on Chromatic |
intergalacticspacehighway
approved these changes
Dec 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I found this PR has improved the keyboard on iOS, we can remove dirty lib to work around this.
at the same time maybe can fix this issue.
How
on iOS, use the
automaticallyAdjustKeyboardInsetsprop +InputAccessoryViewto handle the keyboard, it's better and smooth now.on other platforms, not any changes.
Test Plan
check if the keyboard works well and smoothly now.
Screen.Recording.2022-12-08.at.17.06.25.mov