Skip to content

handle uncaughtException #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2019
Merged

handle uncaughtException #114

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8d6602
handle uncaughtException
niieani Mar 5, 2019
0bf2b23
pass down the filePath verbatim
shellscape Mar 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/routes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,13 @@ const setupRoutes = function setupRoutes() {
}
};

socket.invalid = (filePath = '<unknown>', compiler) => {
socket.invalid = (filePath, compiler) => {
if (socket.readyState === 3) {
return;
}

const context = compiler.context || compiler.options.context || process.cwd();
const fileName = filePath.replace(context, '');
const fileName = typeof filePath === 'string' ? filePath.replace(context, '') : '<unknown>';
const { wpsId } = compiler;

socket.send(prep({ action: 'invalid', data: { fileName, wpsId } }));
Expand Down