Skip to content

💥 Use string error codes #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2023
Merged

💥 Use string error codes #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions lib/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
class InvalidCollectionNameError extends Error {
constructor() {
super();
this.code = 'ERR_INVALID_COLLECTION_NAME';
this.message = 'Must provide valid collection name';
}
}

class InvalidIdError extends Error {
constructor() {
super();
this.code = 'ERR_INVALID_ID';
this.message = 'Must provide valid ID';
}
}

class InvalidSnapshotError extends Error {
constructor() {
super();
this.code = 'ERR_INVALID_SNAPSHOT';
this.message = 'Must provide valid snapshot';
}
}

class InvalidVersionError extends Error {
constructor() {
super();
this.code = 'ERR_INVALID_VERSION';
this.message = 'Must provide valid integer version or null';
}
}

class InvalidTimestampError extends Error {
constructor() {
super();
this.code = 'ERR_INVALID_TIMESTAMP';
this.message = 'Must provide valid integer timestamp or null';
}
}

class MongoClosedError extends Error {
constructor() {
super();
this.code = 'MONGO_CLOSED';
this.message = 'Already closed';
}
}

module.exports = {
InvalidCollectionNameError,
InvalidIdError,
InvalidSnapshotError,
InvalidVersionError,
InvalidTimestampError,
MongoClosedError,
};
65 changes: 9 additions & 56 deletions lib/mongo-milestone-db.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
const MilestoneDB = require('sharedb').MilestoneDB;
const mongodbRequire = require('./mongodb');
const errors = require('./errors');

class MongoMilestoneDB extends MilestoneDB {
constructor(mongo, options) {
Expand Down Expand Up @@ -46,8 +47,8 @@ class MongoMilestoneDB extends MilestoneDB {
};
}

if (!collectionName) return process.nextTick(callback, new InvalidCollectionNameError());
if (!snapshot) return process.nextTick(callback, new InvalidSnapshotError());
if (!collectionName) return process.nextTick(callback, new errors.InvalidCollectionNameError());
if (!snapshot) return process.nextTick(callback, new errors.InvalidSnapshotError());

this._saveMilestoneSnapshot(collectionName, snapshot)
.then(() => {
Expand Down Expand Up @@ -88,9 +89,9 @@ class MongoMilestoneDB extends MilestoneDB {
}

_getMilestoneSnapshotByVersion(collectionName, id, version) {
if (!id) return Promise.reject(new InvalidIdError());
if (!id) return Promise.reject(new errors.InvalidIdError());
if (!this._isValidVersion(version)) {
return Promise.reject(new InvalidVersionError());
return Promise.reject(new errors.InvalidVersionError());
}

const query = {d: id};
Expand All @@ -106,9 +107,9 @@ class MongoMilestoneDB extends MilestoneDB {
}

_getMilestoneSnapshotByTimestamp(collectionName, id, timestamp, isAfterTimestamp) {
if (!id) return Promise.reject(new InvalidIdError());
if (!id) return Promise.reject(new errors.InvalidIdError());
if (!this._isValidTimestamp(timestamp)) {
return Promise.reject(new InvalidTimestampError());
return Promise.reject(new errors.InvalidTimestampError());
}

const limit = 1;
Expand Down Expand Up @@ -136,7 +137,7 @@ class MongoMilestoneDB extends MilestoneDB {
}

_getMilestoneSnapshotByQuery(collectionName, query, options) {
if (!collectionName) return Promise.reject(new InvalidCollectionNameError());
if (!collectionName) return Promise.reject(new errors.InvalidCollectionNameError());

return this._collection(collectionName)
.then(collection => collection.findOne(query, options))
Expand All @@ -153,7 +154,7 @@ class MongoMilestoneDB extends MilestoneDB {

_client() {
if (!this._mongoPromise) {
return Promise.reject(new MongoClosedError());
return Promise.reject(new errors.MongoClosedError());
}

return this._mongoPromise;
Expand Down Expand Up @@ -253,52 +254,4 @@ class MongoMilestoneDB extends MilestoneDB {
}
}

class InvalidCollectionNameError extends Error {
constructor() {
super();
this.code = 4101;
this.message = 'Must provide valid collection name';
}
}

class InvalidIdError extends Error {
constructor() {
super();
this.code = 4102;
this.message = 'Must provide valid ID';
}
}

class InvalidSnapshotError extends Error {
constructor() {
super();
this.code = 4103;
this.message = 'Must provide valid snapshot';
}
}

class InvalidVersionError extends Error {
constructor() {
super();
this.code = 4104;
this.message = 'Must provide valid integer version or null';
}
}

class InvalidTimestampError extends Error {
constructor() {
super();
this.code = 4105;
this.message = 'Must provide valid integer timestamp or null';
}
}

class MongoClosedError extends Error {
constructor() {
super();
this.code = 5101;
this.message = 'Already closed';
}
}

module.exports = MongoMilestoneDB;