⬆️ Add support for mongodb v4
#12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1033132494
💛 - Coveralls |
ericyhwang
approved these changes
Jul 14, 2021
| const mongodb = require('mongodb'); | ||
|
|
||
| module.exports = { | ||
| mongodb: mongodb, |
There was a problem hiding this comment.
Any particular reason for the extra level of nesting?
There was a problem hiding this comment.
So that we can actively set it in the tests.
This change adds support for [`mongodb` v4][1]. The only [change][2] that seems to affect us is: - removal of the top-level `connect()` function [1]: https://github.com/mongodb/node-mongodb-native/releases/tag/v4.0.0 [2]: https://github.com/mongodb/node-mongodb-native/blob/4.0/docs/CHANGES_4.0.0.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for
mongodbv4. The only changethat seems to affect us is:
connect()function