-
Notifications
You must be signed in to change notification settings - Fork 0
Add --scratch flag for experimental demos #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
730af50
Add --scratch flag to create demos in gitignored directory
justin808 a716bf9
Add demo metadata JSON file generation
justin808 7fd66d4
shakapacker main
justin808 c182be0
Add --force flag to Rails generators for non-interactive demo creation
justin808 9a2be42
Add automatic Playwright browser installation with --skip-playwright …
justin808 459827e
Change demo metadata format from JSON to YAML
justin808 f4344c5
Add --typescript flag for unified TypeScript setup
justin808 27caad6
Remove --force flag from shakapacker:install command
justin808 c762de2
Let React on Rails handle TypeScript setup
justin808 f461df0
Add --skip flag to react_on_rails:install to prevent interactive prompts
justin808 7e05fbf
Add automated testing and improve completion message
justin808 eb77a55
Remove conflicting files before React on Rails installation
justin808 589bf46
Fix: Don't delete shakapacker.yml - let React on Rails overwrite it
justin808 0a4f9de
Remove automated testing - requires complex background process manage…
justin808 01b6bfa
Use THOR_MERGE=always to prevent interactive prompts
justin808 735892a
Fix: Install Playwright browsers after npm install completes
justin808 4070abd
Add comprehensive E2E testing with Playwright
justin808 7809482
Fix: Remove non-existent cypress-playwright-on-rails gem dependency
justin808 19e990b
Fix: Add Playwright to package.json in demo_common generator
justin808 0339ac5
Fix: Create .gitignore if it doesn't exist in demo_common generator
justin808 259c11e
Add cypress-on-rails gem integration for Playwright
justin808 2a901e0
Let cypress-on-rails handle Playwright installation
justin808 ffd18c7
Fix: Use --force flag instead of THOR_MERGE environment variable
justin808 879ae30
Use -f instead of --force for Rails generator
justin808 2df1d3b
Fix code review issues: process management, YAML generation, and clarity
justin808 39b3d3a
Add --typescript and --skip-playwright flags to reconstruct_command
justin808 a8d8fcf
Update default versions to match .new-demo-versions
justin808 0506503
Fix e2e.rake to use File::NULL for cross-platform compatibility
justin808 3cf5491
Add prerelease flags to demo metadata and test coverage
justin808 613d1ac
Add prerelease flags to reconstruct_command and test coverage
justin808 ecea074
Refactor e2e.rake and add demo_name validation
justin808 967b38d
Fix critical process group management in E2eTestRunner
justin808 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metadata drops prerelease intent.
shakapacker_prerelease/react_on_rails_prereleaseare never recorded astrue; the hash insertsfalsefor GitHub specs and drops everything else via.compact. If a demo was generated with--shakapacker-prereleaseor--react-on-rails-prerelease, the emitted metadata now misrepresents those options, so readers can’t reconstruct the original command accurately. Please persist the actual flag values (e.g., store the incoming booleans or expose them fromConfig) instead of the current hard-coded false/nil logic.🤖 Prompt for AI Agents